Use a ResizeObserver to detect changes in canvas size
#1121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmarti
changed the title
ResizeObserver to detect changes canvas sizeResizeObserver to detect changes in canvas size
xeolabs
added a commit
that referenced
this pull request
Aug 31, 2023
xeolabs
added a commit
that referenced
this pull request
Aug 31, 2023
|
@tmarti I wonder if this BIMViewer issue is somehow related: xeokit/xeokit-bim-viewer#155 |
|
I think so; for the perspective case this commit in this PR should solve it: I think the same should be done for the ortho case? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Today, in each scene
tick, the canvas and window sizes are compared to their previous values to detect if the pixel-size of the canvas needs to be updated. By doing that, calls happen to.clientWidthand.clientHeightproperties, and this can trigger DOM layout calculations per-tick, which adds overhead to the rendering process (according to Chrome Profiler).Instead, this PR pretty much simplifies the mechanism and delegates the knowledge about if the canvas resized to a
ResizeObserver, which avoids to kick any extra DOM layout calculation. With this the resize-handling code gets simpler and more performant.Bonus track
Also, when the
Perspectivematrix is updated, the class will make sure to mark itsCameraas "dirty" so it updates the matrix. This is needed in some cases so the camera gets aware that the x/y axis-ratio has changed, as the aspect ratio is handled on the projection matrix.Reference
ResizeObserveris supported on all major browsers since around 3 years ago: